This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Upgrade Rust #6
Merged
Upgrade Rust #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should make the whole decoder business easy to maintainable. currently this change is available to Korean and Japanese codecs.
this also keeps up with the recent WHATWG spec changes, including a merge of GBK18030 with GB18030.
previously it didn't depend on the encoder state at all, resulting in the incorrect output when the encoder has a complex state. this directly affects ISO 2022 encodings in the development.
- the last codec error is now stored in the intermediate context, so the state machine can use a code like `ctx.err(..), S1(ctx)`. - fixed a performance regression due to the decoder generalization. the decoder performance should be on par with hand-written one (less than 10% difference) with `--opt-level=3 -Z lto` rustc flags.
this also tries to fix a possible interference issue between the benchmark and aggressive optimization passes.
this greatly improves backward mapping performance, with improvements ranging from 50% to 400%. this also allows for the exact accounting of the binary size overhead.
Rebuild when external dependencies change
this also changes names of Macintosh encodings from `encoding::all` to stay away from names assigned by WHATWG Encoding Standard.
|
r? @SimonSapin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a merge from upsream