This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
support android build and glue #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't pretty, but will have to do for now. A better fix @brson suggests is to refactor stuff so that libservo doesn't talk to the windowing system. This is going to be required anyway for embedding, so this android-glue hack will eventually go away. |
metajack
added a commit
that referenced
this pull request
Aug 13, 2013
support android build and glue
|
@metajack We are agreed to your opinion eventually. The reason of using android version of freeglut is servo originally used freeglut. But there is some differences between them actually. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed according to your advice.
Is it fine?
As Ilyong's comment, actually It is needed android-glue in android.
we need to separate the each platforms in makefile.in?
we added linking libandroid-glut.a on making librustglut.so.
It will be fine at linux or macos build.
however it seems not obious for other people so that it may causes some confusion.
I don't know what is better. shorter code is better or clear code is better..
Let me know your opinion, and we will be very appreciated.