Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support android build and glue #28

Merged
merged 1 commit into from Aug 13, 2013
Merged

support android build and glue #28

merged 1 commit into from Aug 13, 2013

Conversation

@aydinkim
Copy link
Contributor

aydinkim commented Aug 12, 2013

Fixed according to your advice.
Is it fine?

As Ilyong's comment, actually It is needed android-glue in android.
we need to separate the each platforms in makefile.in?
we added linking libandroid-glut.a on making librustglut.so.
It will be fine at linux or macos build.
however it seems not obious for other people so that it may causes some confusion.
I don't know what is better. shorter code is better or clear code is better..

Let me know your opinion, and we will be very appreciated.

@metajack
Copy link
Contributor

metajack commented Aug 13, 2013

This isn't pretty, but will have to do for now.

A better fix @brson suggests is to refactor stuff so that libservo doesn't talk to the windowing system. This is going to be required anyway for embedding, so this android-glue hack will eventually go away.

metajack added a commit that referenced this pull request Aug 13, 2013
support android build and glue
@metajack metajack merged commit 714ee04 into servo:master Aug 13, 2013
@aydinkim
Copy link
Contributor Author

aydinkim commented Aug 13, 2013

@metajack We are agreed to your opinion eventually. The reason of using android version of freeglut is servo originally used freeglut. But there is some differences between them actually.
And currently servo's window system has changed to glfw, unfortunately, glfw doesn't support android port yet.
We are now considering this issue and it can be resolved step by step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.