Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphite2/icu api support #171

Open
ratmice opened this issue Oct 6, 2019 · 2 comments
Open

graphite2/icu api support #171

ratmice opened this issue Oct 6, 2019 · 2 comments

Comments

@ratmice
Copy link

ratmice commented Oct 6, 2019

I have a really terrible set of patches, for building harfbuzz with graphite2/icu support,
and setting environment variables via CARGO_DEP_* so that further C libraries can link against everything,

graphite2 stuff is based upon a lightly modified version of @spl's graphite2-sys crate.

I guess I am curious what the appropriate route to upstreaming is (after getting rid of some of the terribleness),
I assume that I should implement cargo features for icu and graphite2, and control the --enable lines from features?

I haven't really used any sys libs with optional features before, so i'm curious if this is amicable to upstream...

master...ratmice:master

@waywardmonkeys
Copy link
Collaborator

This would conflict with the changes that I'm also working on in #170 ... Have you seen those? It might simplify some of the build issues on the Harfbuzz side.

@ratmice
Copy link
Author

ratmice commented Oct 7, 2019

I've briefly looked at them, and believe I understand the gist of it,

I'm guessing that, I'd need to make some cargo features, and in the big amalgamation source file, these features would need #ifdef or whatever macro conditional, and then have cc crate define these on compile? Anyhow I will have a look at implementing it atop that patch and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants