Experimental change to use harfbuzz unity build. #170
Conversation
waywardmonkeys
force-pushed
the
try-harfbuzz-unity-build
branch
2 times, most recently
from
97aadf4
to
c005186
Compare
|
@jdm I think my only real concern about this at this point is how things are on Android since the build system has changed entirely ... (And that I need to amend the commit to have a better message) |
|
@waywardmonkeys are you going to test on Android? |
|
@jrmuizel How would I test on Android? (I don't do any Android work ...) Is that something that @bors-servo can do? |
waywardmonkeys
force-pushed
the
try-harfbuzz-unity-build
branch
from
c005186
to
c32f323
Compare
|
@bors-servo try |
Experimental change to use harfbuzz unity build. This is a test to see what happens if we switch to using the unity build for harfbuzz. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/170) <!-- Reviewable:end -->
|
💔 Test failed - checks-travis |
waywardmonkeys
force-pushed
the
try-harfbuzz-unity-build
branch
2 times, most recently
from
d6ad617
to
896d1e9
Compare
|
I forgot to add a change to my commit. :( Testing again ... |
|
@bors-servo try |
Experimental change to use harfbuzz unity build. This is a test to see what happens if we switch to using the unity build for harfbuzz. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/170) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
|
@jdm Let's move forward on merging this? This would have avoided the issue that @SimonSapin had as well ... in addition to improving our builds for iOS and WebAssembly. |
|
@waywardmonkeys Are the only concerns about whether this will break the build on android? If so, it would be straightforward to add a patch to https://github.com/servo/servo/blob/master/Cargo.toml to use this branch and send it through our CI to verify that everything still builds. |
|
That is my only concern, yes. |
This simplifies our build and makes it faster. It also makes it easier to support on additional platforms via cross-compilation.
jdm
force-pushed
the
try-harfbuzz-unity-build
branch
from
896d1e9
to
c5ea9e9
Compare
|
Getting build results from servo/servo#24784. |
|
@bors-servo r+ |
|
📌 Commit c5ea9e9 has been approved by |
Experimental change to use harfbuzz unity build. This is a test to see what happens if we switch to using the unity build for harfbuzz. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/170) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
|
Thanks! |
Update harfbuzz-sys to 0.3.4. Publish the changes from #170.
This is a test to see what happens if we switch to using the unity build for harfbuzz.
This change is