Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upA round of rust-layers cleanups #76
Merged
Conversation
CommonLayer is only used by ContainerLayer, so it can be moved directly into ContainerLayer. A vector can also be used for storing children instead of an embedded linked-list since the operations we do on the list of children are still very limited.
This is currently unused in Servo.
pcwalton
added a commit
that referenced
this pull request
Jul 3, 2014
A round of rust-layers cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJul 2, 2014
This PR contains various rust-layers cleanups, including the removal of dead code and general simplification. This is in preparation for a more thorough rework of the tiling code.