Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for constant generics #204

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Mar 17, 2020

No breaking changes and no internal hacks. This PR only adds a feature to switch between implementations of the Array trait.

I personally think that this approach is pretty reasonable and should be at least considered for discussion.

@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 18, 2020

Cool, thanks! It looks like the .travis.yml file needs some updates to make the tests pass in CI, but otherwise this looks great.

@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 18, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2020

📌 Commit 70e967e has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2020

Testing commit 70e967e with merge 9cdf8fb...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 18, 2020

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing 9cdf8fb to master...

@bors-servo bors-servo merged commit 9cdf8fb into servo:master Mar 18, 2020
1 of 2 checks passed
@c410-f3r
Copy link
Contributor Author

c410-f3r commented Mar 18, 2020

Thank you! Thank you very much!

@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 18, 2020

Let me know if you need this published to crates.io soon; otherwise we will probably wait until we have a few more changes before making a new release.

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Mar 25, 2020

I am fine using the git version and now that this change is upstream, everything is cool. Thank you one more time.

mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Apr 6, 2020
* Add a new unstable `const_generics` feature (servo#204).
* Improve inlining of constructor functions (servo#206).
* Add a `slice.to_smallvec()` convenience method (servo#203).
* Documentation and testing improvements.
@mbrubeck mbrubeck mentioned this pull request Apr 6, 2020
bors-servo added a commit that referenced this issue Apr 8, 2020
Version 1.3.0

* Add a new unstable `const_generics` feature (#204).
* Improve inlining of constructor functions (#206).
* Add a `slice.to_smallvec()` convenience method (#203).
* Documentation and testing improvements.
@c410-f3r c410-f3r mentioned this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants