Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Array for all sizes <= 32 #234

Merged
merged 1 commit into from Sep 8, 2020

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Sep 8, 2020

Most traits supported by arrays are fully supported for arrays in the Rust stdlib as for all sizes <= 32. I was surprised to find that SmallVec<[T; 18]> (I happen to know that 18 the maximum outside of obscure cases) isn't possible because smallvec::Array is not consistent with this pattern.

Of course, I don't actually need this — I can just choose another size, but it seems like it would be good/unsurprising to be a superset of libstd's choices here.

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 8, 2020

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2020

📌 Commit 604b3fe has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2020

Testing commit 604b3fe with merge caea701...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2020

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing caea701 to master...

@bors-servo bors-servo merged commit caea701 into servo:master Sep 8, 2020
1 of 2 checks passed
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Nov 16, 2020
Change log:

* Add the `append` method (servo#237).
* Add support for more array sizes between 17 and 31 (servo#234).
* Don't panic on deserialization errors (servo#238).
@mbrubeck mbrubeck mentioned this pull request Nov 16, 2020
bors-servo added a commit that referenced this issue Nov 17, 2020
Version 1.5.0

Change log:

* Add the `append` method (#237).
* Add support for more array sizes between 17 and 31 (#234).
* Don't panic on deserialization errors (#238).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants