Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on arithmetic overflow in drain #259

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Panic on arithmetic overflow in drain #259

merged 1 commit into from
Mar 23, 2021

Conversation

mbrubeck
Copy link
Collaborator

Fixes #258.

emilio
emilio approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way looks good.

src/lib.rs Outdated Show resolved Hide resolved
@mbrubeck
Copy link
Collaborator Author

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit c3e7f21 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit c3e7f21 with merge 503ce70...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: emilio
Pushing 503ce70 to master...

@bors-servo bors-servo merged commit 503ce70 into servo:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential integer overflow in drain leading to draining thinks when it should be out of bounds.
3 participants
@mbrubeck @bors-servo @emilio