url: reject empty host after toAscii conversion

Per the change in whatwg/url#497.
servo · Aug 18, 2020 · 6b05499 · 6b05499
1 parent 0a92c73
commit 6b05499
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 20 deletions.
diff --git a/src/host.rs b/src/host.rs
@@ -82,6 +82,9 @@ impl Host<String> {
         }
         let domain = percent_decode(input.as_bytes()).decode_utf8_lossy();
         let domain = idna::domain_to_ascii(&domain)?;
+        if domain.is_empty() {
+            return Err(ParseError::EmptyHost);
+        }
         if domain
             .find(|c| {
                 matches!(

diff --git a/tests/setters_tests.json b/tests/setters_tests.json
@@ -950,16 +950,6 @@
                 "port": ""
             }
         },
-        {
-            "href": "file://hi/x",
-            "new_value": "",
-            "expected": {
-                "href": "file:///x",
-                "host": "",
-                "hostname": "",
-                "port": ""
-            }
-        },
         {
             "href": "sc://test@test/",
             "new_value": "",
@@ -1284,16 +1274,6 @@
                 "port": ""
             }
         },
-        {
-            "href": "file://hi/x",
-            "new_value": "",
-            "expected": {
-                "href": "file:///x",
-                "host": "",
-                "hostname": "",
-                "port": ""
-            }
-        },
         {
             "href": "sc://test@test/",
             "new_value": "",