Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid IPv4 addresses are not rejected #116

Closed
nox opened this issue Jun 13, 2015 · 3 comments · Fixed by #138
Closed

Invalid IPv4 addresses are not rejected #116

nox opened this issue Jun 13, 2015 · 3 comments · Fixed by #138
Labels
bug

Comments

@nox
Copy link
Contributor

nox commented Jun 13, 2015

https://github.com/w3c/web-platform-tests/blob/11f3aee19205a2ae97efa1cbeb211a2395192ea8/url/urltestdata.txt#L325
@nox nox added the bug label Jun 13, 2015
@SimonSapin
Copy link
Member

I believe this test does not match the current spec, but in this case I think the spec should be changed. Spec issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26431

@pyfisch pyfisch mentioned this issue Nov 14, 2015
Merged
@frewsxcv
Copy link
Contributor

Spec has been resolved

@pyfisch pyfisch mentioned this issue Nov 20, 2015
Merged
bors-servo pushed a commit that referenced this issue Nov 20, 2015
Auto merge of #138 - pyfisch:ipaddrs, r=SimonSapin
ff8e8c9 
Change host to use ip address types provided by std.

Removes the custom IPv6Addr type and replaces it with the std one.
Parses IPv4Addrs to the std type using the parser described in the
url.spec.whatwg.org handling all edge cases. Add tests.

fixes #116

This is a breaking change. Version bumped to v0.5.0.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/138)
<!-- Reviewable:end -->
@nox
Copy link
Contributor Author

nox commented Nov 21, 2015

This was closed, but we never added http://192.168.0.257 to the tests.

@frewsxcv frewsxcv mentioned this issue Nov 21, 2015
Closed
@zackw zackw mentioned this issue May 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change host to use ip address types provided by std.
3 participants
@nox @SimonSapin @frewsxcv