Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded fragment percent encode set for URL fragments. #491
Conversation
|
|
|
Your assessment seems to be correct. I'll check upstream if the tests changed, given the tests are supposed to follow the spec and your interpretation of the spec seems correct to me. |
Yep, upstream tests were changed and we are just not aligned anymore. |
nox
added a commit
that referenced
this pull request
Jul 19, 2019
> test result: FAILED. 637 passed; 76 failed; 0 ignored; 0 measured
o0Ignition0o
added a commit
to o0Ignition0o/rust-url
that referenced
this pull request
Aug 16, 2019
> test result: FAILED. 637 passed; 76 failed; 0 ignored; 0 measured
o0Ignition0o
added a commit
to o0Ignition0o/rust-url
that referenced
this pull request
Sep 3, 2019
> test result: FAILED. 637 passed; 76 failed; 0 ignored; 0 measured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ulf5 commentedMar 22, 2019
•
edited by larsbergstrom
Hello!
I noticed that the spec here defines a fragment percent encode set:
https://url.spec.whatwg.org/#percent-encoded-bytes
It seemed to me that rust-url was using the SIMPLE_ENCODE_SET while parsing the fragment and that it should be using the fragment encode set instead:
https://url.spec.whatwg.org/#url-parsing
I made this PR which should fix it, or have I got it wrong?
This change is