Non-special URLs can have their paths erased #919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage ? 81.79%
=======================================
Files ? 20
Lines ? 3553
Branches ? 0
=======================================
Hits ? 2906
Misses ? 647
Partials ? 0 ☔ View full report in Codecov by Sentry. |
valenting
requested changes
Apr 2, 2024
url/src/quirks.rs
Outdated
| let mut path_to_set = String::from("/"); | ||
| path_to_set.push_str(new_pathname); | ||
| url.set_path(&path_to_set) | ||
| } | ||
| else { | ||
| url.set_path(new_pathname) | ||
| } |
There was a problem hiding this comment.
Please fix the cargo fmt issues https://github.com/servo/rust-url/actions/runs/8513766904/job/23336162537?pr=919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bug 1874117 with reviewer @valenting