Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed uses of unwrap in compositor. #10424

Merged
merged 1 commit into from Apr 6, 2016
Merged

Removed uses of unwrap in compositor. #10424

merged 1 commit into from Apr 6, 2016

Conversation

asajeffrey
Copy link
Member

Fixes #10421.

This change is Reviewable

@wafflespeanut
Copy link
Contributor

@bors-servo r+

We have soooo many unwraps!!!

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bors-servo
Copy link
Contributor

📌 Commit 167b6ca has been approved by Wafflespeanut

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 6, 2016
@wafflespeanut wafflespeanut self-assigned this Apr 6, 2016
@asajeffrey
Copy link
Member Author

@wafflespeanut: there's fewer unrestored than before! Thanks for the r+.

@asajeffrey
Copy link
Member Author

s/unrestored/unwraps/ thank you autocorrect.

@bors-servo
Copy link
Contributor

⌛ Testing commit 167b6ca with merge 0e51be0...

bors-servo pushed a commit that referenced this pull request Apr 6, 2016
Auto merge of #10424 - asajeffrey:compositor-hardening, r=Wafflespeanut
0e51be0 
Removed uses of unwrap in compositor.

Fixes #10421.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10424)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 167b6ca into servo:master Apr 6, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asajeffrey @wafflespeanut @bors-servo @highfive