Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust to 1.13.0-nightly (198713106 2016-08-26) #13055

Merged
merged 1 commit into from Aug 28, 2016
Merged

Update Rust to 1.13.0-nightly (198713106 2016-08-26) #13055

merged 1 commit into from Aug 28, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented Aug 26, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/browsingcontext.rs, components/script/Cargo.toml, components/script/dom/bindings/utils.rs, components/script_layout_interface/Cargo.toml

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 26, 2016
@nox
Copy link
Contributor Author

nox commented Aug 26, 2016

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit ab88f68 with merge a078a57...

bors-servo pushed a commit that referenced this pull request Aug 26, 2016
Auto merge of #13055 - servo:rustup, r=<try>
a078a57 
(Do not merge) Update Rust to 1.13.0-nightly (e07dd59ea 2016-08-25)
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 26, 2016
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Aug 26, 2016
@nox
Copy link
Contributor Author

nox commented Aug 26, 2016

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 7432e3a with merge 173466b...

bors-servo pushed a commit that referenced this pull request Aug 26, 2016
Auto merge of #13055 - servo:rustup, r=<try>
173466b 
(Do not merge) Update Rust to 1.13.0-nightly (e07dd59ea 2016-08-25)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13055)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 26, 2016
@metajack
Copy link
Contributor

r=me

And hooray for memshrinkage!

@nox
Copy link
Contributor Author

nox commented Aug 26, 2016

@bors-servo clean try

@nox
Copy link
Contributor Author

nox commented Aug 26, 2016

@bors-servo clean try-

@nox
Copy link
Contributor Author

nox commented Aug 26, 2016

@bors-servo try clean

@nox
Copy link
Contributor Author

nox commented Aug 26, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Trying commit 7432e3a with merge a88c81e...

bors-servo pushed a commit that referenced this pull request Aug 26, 2016
Auto merge of #13055 - servo:rustup, r=<try>
a88c81e 
(Do not merge) Update Rust to 1.13.0-nightly (e07dd59ea 2016-08-25)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13055)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 26, 2016
@nox
Copy link
Contributor Author

nox commented Aug 26, 2016

zmike/cef-rebase#1

@nox
Copy link
Contributor Author

nox commented Aug 26, 2016 

Tests with unexpected results:
  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html
  │ 
  └ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".

This is #13059.

@nox nox added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. S-tests-failed The changes caused existing tests to fail. labels Aug 26, 2016
@nox nox added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Aug 27, 2016
@nox nox mentioned this pull request Aug 28, 2016
Merged
5 tasks
@nox nox changed the title (Do not merge) Update Rust to 1.13.0-nightly (e07dd59ea 2016-08-25) (Do not merge) Update Rust to 1.13.0-nightly (198713106 2016-08-26) Aug 28, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Aug 28, 2016
@nox
Copy link
Contributor Author

nox commented Aug 28, 2016

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 43d22e4 with merge aac8004...

bors-servo pushed a commit that referenced this pull request Aug 28, 2016
Auto merge of #13055 - servo:rustup, r=<try>
aac8004 
(Do not merge) Update Rust to 1.13.0-nightly (198713106 2016-08-26)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13055)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@nox
Copy link
Contributor Author

nox commented Aug 28, 2016

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

📌 Commit c66380d has been approved by metajack

@highfive highfive assigned metajack and unassigned glennw Aug 28, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 28, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit c66380d with merge 1c2b45f...

bors-servo pushed a commit that referenced this pull request Aug 28, 2016
Auto merge of #13055 - servo:rustup, r=metajack
1c2b45f 
(Do not merge) Update Rust to 1.13.0-nightly (198713106 2016-08-26)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13055)
<!-- Reviewable:end -->
@nox nox removed the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Aug 28, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit c66380d into master Aug 28, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 28, 2016
@nox nox changed the title (Do not merge) Update Rust to 1.13.0-nightly (198713106 2016-08-26) Update Rust to 1.13.0-nightly (198713106 2016-08-26) Aug 28, 2016
@nox nox deleted the rustup branch August 28, 2016 14:11
@nox
Copy link
Contributor Author

nox commented Aug 28, 2016

Forgot to remove "(Do not merge)" damn. Anyway, for the record: this was ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @bors-servo @metajack @glennw