layout: Improve the interaction between baseline-offset-of-last-line-in-flow logic and inline absolute hypothetical boxes. #13470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and an inline flow has no applicable lines, continue checking previous sibling flows. Improves Twitter by placing the favorite icon in the right place.
|
|
highfive
added
the
S-awaiting-review
notriddle
reviewed
Sep 28, 2016
| None | ||
| } else { | ||
| Some(last_line.bounds.start.b + last_line.bounds.size.block - | ||
| last_line.inline_metrics.depth_below_baseline) |
There was a problem hiding this comment.
In cases like this:
Some text<br><span style="position:absolute">la la la</span>I would expect the last line to be made up entirely of hypothetical boxes ("la la la"), so baseline_offset_of_last_line should, in this case, return the baseline offset of "Some text", not None, right?
There was a problem hiding this comment.
Oh yes, of course. I'll fix.
determining the baseline offset of the last line. Improves Twitter by placing the favorite icon in the right place vertically.
pcwalton
force-pushed
the
inline-absolute-hypothetical-baseline
branch
from
e26d260
to
b021952
Compare
|
Addressed. r? @notriddle |
notriddle
approved these changes
Sep 28, 2016
| } | ||
| } | ||
| None |
There was a problem hiding this comment.
This is a massive improvement!
|
@bors-servo r+ |
|
📌 Commit b021952 has been approved by |
highfive
added
S-awaiting-merge
|
📌 Commit b021952 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 29, 2016
…, r=notriddle layout: Improve the interaction between baseline-offset-of-last-line-in-flow logic and inline absolute hypothetical boxes. See commits for details. These changes place the heart icon on Twitter in the right place. r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13470) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details. These changes place the heart icon on Twitter in the right place.
r? @notriddle
This change is