Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mouse position when receiving mouse wheel events #15333

Merged
merged 1 commit into from Feb 2, 2017
Merged

update mouse position when receiving mouse wheel events #15333

merged 1 commit into from Feb 2, 2017

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Feb 1, 2017 •
edited by larsbergstrom

Rebase of #14808.

This change is Reviewable

@mbrubeck mbrubeck self-assigned this Feb 1, 2017
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2017
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Feb 1, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 7717e83 has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 1, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 7717e83 with merge 8b9dc93...

bors-servo pushed a commit that referenced this pull request Feb 1, 2017
Auto merge of #15333 - mbrubeck:update_mouse_position_when_receiving_…
8b9dc93 
…wheel_events, r=mbrubeck

update mouse position when receiving mouse wheel events

Rebase of #14808.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14290 (github issue number if applicable).
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15333)
<!-- Reviewable:end -->
@mbrubeck mbrubeck mentioned this pull request Feb 1, 2017
Closed
5 tasks
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

@bors-servo bors-servo merged commit 7717e83 into servo:master Feb 2, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 2, 2017
@mbrubeck mbrubeck deleted the update_mouse_position_when_receiving_wheel_events branch May 2, 2017 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When Servo isn't the window directly in front, scroll is stuck in previously scrolled layer
4 participants
@mbrubeck @bors-servo @highfive @gterzian