Fix parsing methods of column-{gap,width} #15662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files: |
highfive
added
the
S-awaiting-review
|
r? @upsuper or @Manishearth |
emilio
reviewed
Feb 20, 2017
| spec="https://drafts.csswg.org/css-multicol/#propdef-column-gap"> | ||
| use std::fmt; | ||
| use style_traits::ToCss; | ||
| use values::HasViewportPercentage; |
There was a problem hiding this comment.
Are these imports really necessary? huh
|
@bors-servo delegate+ |
|
✌️ @canaltinova can now approve this pull request |
|
@emilio After discussing with @Manishearth, I reverted changes on longhands. Instead deleted previous generic |
|
@bors-servo r+ |
|
📌 Commit 19978f2 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 20, 2017
Fix parsing methods of column-{gap,width}
<!-- Please describe your changes on the following line: -->
They weren't accepting {normal, auto} keywords. Fixed parsing methods of these properties.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15088 (github issue number if applicable).
<!-- Either: -->
- [X] There are tests for these changes
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15662)
<!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They weren't accepting {normal, auto} keywords. Fixed parsing methods of these properties.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is