Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servo-tidy to 0.3.0 #15731

Merged
merged 1 commit into from Feb 25, 2017
Merged

Update servo-tidy to 0.3.0 #15731

merged 1 commit into from Feb 25, 2017

Conversation

UK992
Copy link
Contributor

@UK992 UK992 commented Feb 24, 2017

r? @wafflespeanut

It's ready to publishing to PyPI.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/tidy/README.rst, python/tidy/HISTORY.rst, python/tidy/setup.py

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 24, 2017
@UK992 UK992 force-pushed the tidy branch 3 times, most recently from 481fdcd to af95215 Compare February 24, 2017 22:11
- Added checking for alphabetical order for JSON keys and ``#![feature(...)]``
- Improved duplicated packages checking
- Improved ordering ``use`` statements
- And many others improvements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: other

And, you missed mine - A lint runner for running custom lints 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@wafflespeanut
Copy link
Contributor

r=me after addressing that :)

@bors-servo delegate+

@bors-servo
Copy link
Contributor

✌️ @UK992 can now approve this pull request

@wafflespeanut
Copy link
Contributor

@bors-servo r+

(cc @edunham)

@bors-servo
Copy link
Contributor

📌 Commit 9f55e66 has been approved by Wafflespeanut

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 25, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 9f55e66 with merge 524ba6a...

bors-servo pushed a commit that referenced this pull request Feb 25, 2017
Update `servo-tidy` to 0.3.0

r? @wafflespeanut

It's ready to publishing to PyPI.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15731)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: Wafflespeanut
Pushing 524ba6a to master...

@bors-servo bors-servo merged commit 9f55e66 into servo:master Feb 25, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants