Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: update ns_timing_function #15863

Merged
merged 2 commits into from Mar 8, 2017

Conversation

BorisChiou
Copy link
Contributor

@BorisChiou BorisChiou commented Mar 8, 2017

This is an interdependent binding fix for Bug 1248340.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Bug 1248340
  • These changes do not require tests because Bug 1248340 will merge some wpt tests for frames timing function.

This change is Reviewable

Replace mStep with mStepsOrFrames, and panic in From trait for frames timing
function.
@highfive
Copy link

highfive commented Mar 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/structs_debug.rs, components/style/gecko_bindings/sugar/ns_timing_function.rs, components/style/gecko_bindings/structs_release.rs
  • @emilio: components/style/gecko_bindings/structs_debug.rs, components/style/gecko_bindings/sugar/ns_timing_function.rs, components/style/gecko_bindings/structs_release.rs

@highfive
Copy link

highfive commented Mar 8, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 8, 2017
@BorisChiou
Copy link
Contributor Author

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 0e97f07 has been approved by heycam

@highfive highfive assigned heycam and unassigned cbrewster Mar 8, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 8, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 0e97f07 with merge ee3af09...

bors-servo pushed a commit that referenced this pull request Mar 8, 2017
stylo: update ns_timing_function

This is an interdependent binding fix for [Bug 1248340](https://bugzilla.mozilla.org/show_bug.cgi?id=1248340).

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1248340](https://bugzilla.mozilla.org/show_bug.cgi?id=1248340)
- [X] These changes do not require tests because Bug 1248340 will merge some wpt tests for frames timing function.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15863)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: heycam
Pushing ee3af09 to master...

@bors-servo bors-servo merged commit 0e97f07 into servo:master Mar 8, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants