Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Align eRestyle_Subtree value with RESTYLE_DESCENDANTS. #15909

Merged
merged 1 commit into from Mar 11, 2017
Merged

stylo: Align eRestyle_Subtree value with RESTYLE_DESCENDANTS. #15909

merged 1 commit into from Mar 11, 2017

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Mar 11, 2017 •
edited by larsbergstrom

Handle the translation of eRestyle_Subtree into
(RESTYLE_SELF | RESTYLE_DESCENDANTS) in the From impl, too.

This change is Reviewable

@heycam
stylo: Align eRestyle_Subtree value with RESTYLE_DESCENDANTS.
c0996c6 
Handle the translation of eRestyle_Subtree into
(RESTYLE_SELF | RESTYLE_DESCENDANTS) in the From impl, too.
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/restyle_hints.rs
  • @emilio: components/style/restyle_hints.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 11, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@heycam
Copy link
Contributor Author

heycam commented Mar 11, 2017

Reviewed by @bholley in https://bugzilla.mozilla.org/show_bug.cgi?id=1291786.

@bors-servo r=bholley

@bors-servo
Copy link
Contributor

📌 Commit c0996c6 has been approved by bholley

@highfive highfive assigned bholley and unassigned KiChjang Mar 11, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 11, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit c0996c6 with merge 2f8cf6a...

bors-servo pushed a commit that referenced this pull request Mar 11, 2017
Auto merge of #15909 - heycam:hint-subtree, r=bholley
2f8cf6a 
stylo: Align eRestyle_Subtree value with RESTYLE_DESCENDANTS.

Handle the translation of eRestyle_Subtree into
(RESTYLE_SELF | RESTYLE_DESCENDANTS) in the From impl, too.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15909)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: bholley
Pushing 2f8cf6a to master...

@bors-servo bors-servo merged commit c0996c6 into servo:master Mar 11, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@heycam @highfive @bors-servo @bholley @KiChjang