Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement access to CSSMediaRule for stylo #15924

Merged
merged 2 commits into from Mar 13, 2017
Merged

Implement access to CSSMediaRule for stylo #15924

merged 2 commits into from Mar 13, 2017

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Mar 13, 2017 •
edited by larsbergstrom

This is the Servo part of bug 1315601.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko/arc_types.rs, components/style/media_queries.rs, components/style/gecko/media_queries.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, ports/geckolib/glue.rs, components/style/gecko/arc_types.rs, components/style/media_queries.rs, components/style/gecko/media_queries.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 13, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Mar 13, 2017

@bors-servo r=heycam,Manishearth

@bors-servo
Copy link
Contributor

📌 Commit 78f65c1 has been approved by heycam,Manishearth

@highfive highfive assigned heycam and unassigned Manishearth Mar 13, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 13, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 78f65c1 with merge b0b8c46...

bors-servo pushed a commit that referenced this pull request Mar 13, 2017
Auto merge of #15924 - upsuper:bug1315601, r=heycam,Manishearth
b0b8c46 
Implement access to CSSMediaRule for stylo

This is the Servo part of [bug 1315601](https://bugzilla.mozilla.org/show_bug.cgi?id=1315601).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15924)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 13, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 13, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Mar 13, 2017

@bors-servo r=heycam,Manishearth

@bors-servo
Copy link
Contributor

📌 Commit 52c9f4b has been approved by heycam,Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 13, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 52c9f4b with merge cc9fb0b...

bors-servo pushed a commit that referenced this pull request Mar 13, 2017
Auto merge of #15924 - upsuper:bug1315601, r=heycam,Manishearth
cc9fb0b 
Implement access to CSSMediaRule for stylo

This is the Servo part of [bug 1315601](https://bugzilla.mozilla.org/show_bug.cgi?id=1315601).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15924)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: heycam,Manishearth
Pushing cc9fb0b to master...

@bors-servo bors-servo merged commit 52c9f4b into servo:master Mar 13, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 13, 2017
@emilio emilio mentioned this pull request Mar 13, 2017
Closed
@upsuper upsuper deleted the bug1315601 branch March 13, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@upsuper @highfive @bors-servo @heycam @Manishearth