Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Use a threadsafe array for counters #16100

Merged
merged 1 commit into from Mar 23, 2017
Merged

stylo: Use a threadsafe array for counters #16100

merged 1 commit into from Mar 23, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented Mar 23, 2017 •
edited by larsbergstrom

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @emilio: components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/gecko_bindings/structs_debug.rs, components/style/gecko_bindings/structs_release.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 23, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@bholley
Copy link
Contributor Author

bholley commented Mar 23, 2017

@bors-servo r=upsuper p=1

@bors-servo
Copy link
Contributor

📌 Commit e485365 has been approved by upsuper

@highfive highfive assigned upsuper and unassigned Manishearth Mar 23, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 23, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit e485365 with merge 6a9fe88...

bors-servo pushed a commit that referenced this pull request Mar 23, 2017
Auto merge of #16100 - bholley:threadsafe_array_for_counters, r=upsuper
6a9fe88 
stylo: Use a threadsafe array for counters

See https://bugzilla.mozilla.org/show_bug.cgi?id=1348606

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16100)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: upsuper
Pushing 6a9fe88 to master...

@bors-servo bors-servo merged commit e485365 into servo:master Mar 23, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 23, 2017
@bors-servo bors-servo mentioned this pull request Mar 23, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@upsuper upsuper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bholley @highfive @bors-servo @upsuper @Manishearth