Set flex-basis to 0% when omitted in flex shorthand. #17073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
emilio
requested changes
May 29, 2017
| flex_basis: basis.unwrap_or(longhands::flex_basis::SpecifiedValue::zero()), | ||
| // Per spec, this should be SpecifiedValue::zero(), but all | ||
| // browsers currently agree on using `0%`. This is a spec | ||
| // change which hasn't be adopted by browsers. |
There was a problem hiding this comment.
Could you link to the either the spec change or the bug?
emilio
approved these changes
May 29, 2017
|
@bors-servo r=emilio |
|
📌 Commit a6c01b6 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 29, 2017
Set flex-basis to 0% when omitted in flex shorthand. This should fix [bug 1331530](https://bugzilla.mozilla.org/show_bug.cgi?id=1331530). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17073) <!-- Reviewable:end -->
|
💔 Test failed - linux-dev |
highfive
added
S-tests-failed
|
@bors-servo retry |
|
⌛ Testing commit a6c01b6 with merge dae80dc0423132f685b971a1c02425905295842d... |
highfive
added
S-awaiting-merge
|
💔 Test failed - android |
highfive
added
S-tests-failed
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
May 29, 2017
Set flex-basis to 0% when omitted in flex shorthand. This should fix [bug 1331530](https://bugzilla.mozilla.org/show_bug.cgi?id=1331530). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17073) <!-- Reviewable:end -->
|
r? @nox |
emilio
reviewed
May 29, 2017
| flex_basis: basis.unwrap_or(longhands::flex_basis::SpecifiedValue::zero()), | ||
| // Per spec, this should be SpecifiedValue::zero(), but all | ||
| // browsers currently agree on using `0%`. This is a spec | ||
| // change which hasn't be adopted by browsers: |
|
@bors-servo r+ |
|
📌 Commit 4622b2d has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit 4622b2d with merge d865ef8ccd83d83b12a70ab52628eedafe0a290a... |
|
💔 Test failed - android |
highfive
added
S-tests-failed
|
@bors-servo r- Err, please fix the grammar nit :) |
highfive
added
S-awaiting-review
|
@bors-servo r=emilio |
|
📌 Commit acb7242 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 29, 2017
Set flex-basis to 0% when omitted in flex shorthand. This should fix [bug 1331530](https://bugzilla.mozilla.org/show_bug.cgi?id=1331530). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17073) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix bug 1331530.
This change is