New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some redundant animation interpolation code #17157
Conversation
So that we can remove redundant interpolation code for corresponding computed types.
r? @hiikezoe |
@bors-servo try |
⌛ Trying commit 61eb7e0 with merge ef028be12a301257d01e22d5328ce80eb8c52f00... |
Reviewed 1 of 1 files at r1. components/style/properties/helpers/animated_properties.mako.rs, line 365 at r2 (raw file):
What I couldn't find initially was that the corresponding part of this change for stylo. Yeah, it's done in the first commit. Rust trait magic. Great! Comments from Reviewable |
Awesome! Thank you Xidorn! |
💔 Test failed - linux-rel-wpt |
@bors-servo retry |
Remove some redundant animation interpolation code <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17157) <!-- Reviewable:end -->
💔 Test failed - linux-rel-wpt |
Stylo try run looks good so far. There are three different intermittents appear on Servo try run. Based on the content of the tests, I believe they are unrelated to changes here. FWIW:
|
@bors-servo r=hiikezoe |
📌 Commit 61eb7e0 has been approved by |
⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3... |
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
This change is