Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Fix has_author_specified_rules() for rules in XBL stylesheets #17426

Merged

Conversation

aethanyc
Copy link
Contributor

@aethanyc aethanyc commented Jun 20, 2017

This change is reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1372062


This change is Reviewable

…(bug 1372062)

MozReview-Commit-ID: GBFgr5pqROk
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/rule_tree/mod.rs
  • @emilio: components/style/rule_tree/mod.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 20, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@aethanyc
Copy link
Contributor Author

@bors-servo r=heycam p=1 because this needs gecko side changes.

@bors-servo
Copy link
Contributor

📌 Commit 945c3e4 has been approved by heycam

@highfive highfive assigned heycam and unassigned emilio Jun 20, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 20, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 945c3e4 with merge a7ac921...

bors-servo pushed a commit that referenced this pull request Jun 20, 2017
…=heycam

stylo: Fix has_author_specified_rules() for rules in XBL stylesheets

This change is reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1372062

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17426)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing a7ac921 to master...

@bors-servo bors-servo merged commit 945c3e4 into servo:master Jun 20, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants