stylo: Add auto-filled line names to mRepeatAutoLineNameListBefore array #17616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Damn, my bad, yeah 😅 @bors-servo r+ |
|
📌 Commit 6fb403c has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jul 6, 2017
stylo: Add auto-filled line names to mRepeatAutoLineNameListBefore array Line names with `repeat(auto-fill, ...)` were not being added to mRepeatAutoLineNameListBefore. They were being added into mLineNameLists instead. Basically, `subgrid repeat(auto-fill, [abc]) [y z]` was becoming `subgrid repeat(auto-fill, []) [abc] [y z]` in computed value. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17616) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 6, 2017
MozReview-Commit-ID: 8276N81ntiv --HG-- extra : amend_source : 0f40a9f0dd750dfce36ece2928246802b9038d97
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Jul 10, 2017
MozReview-Commit-ID: 8276N81ntiv
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Jul 10, 2017
MozReview-Commit-ID: 8276N81ntiv
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Jul 11, 2017
MozReview-Commit-ID: 8276N81ntiv
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
MozReview-Commit-ID: 8276N81ntiv UltraBlame original commit: 89c5475d5b0fcc8d4739d8e3d430c49f04eb4bbe
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
MozReview-Commit-ID: 8276N81ntiv UltraBlame original commit: 89c5475d5b0fcc8d4739d8e3d430c49f04eb4bbe
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
MozReview-Commit-ID: 8276N81ntiv UltraBlame original commit: 89c5475d5b0fcc8d4739d8e3d430c49f04eb4bbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line names with
repeat(auto-fill, ...)were not being added to mRepeatAutoLineNameListBefore. They were being added into mLineNameLists instead.Basically,
subgrid repeat(auto-fill, [abc]) [y z]was becomingsubgrid repeat(auto-fill, []) [abc] [y z]in computed value../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is