Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Don't rebuild cascade origins that haven't changed. #18060

Merged
merged 13 commits into from Aug 13, 2017
Merged

style: Don't rebuild cascade origins that haven't changed. #18060

merged 13 commits into from Aug 13, 2017

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Aug 13, 2017 •
edited by SimonSapin

@heycam
style: Move Origin into its own file.
0635fdd
@heycam
style: Factor out per-origin data storage.
321643a 
Also add an iter_mut_origins() function.
@heycam
style: Split style sheet invalidations per-origin.
f9d1a0e
@heycam
style: Move cached media query results into per-origin data.
db6a09f
@heycam
style: Move rule source order counter into per-origin data.
57ee17d
@heycam
style: Move cleared state into per-origin data.
72107eb
@heycam
style: Add ability to clear and rebuild individual origins.
f3a7adf
@heycam
style: Only flush stylesheet invalidations for origins that have chan…
84451e5 
…ged.
@heycam
style: Fix origin iteration order.
d90ff18
@heycam
style: Make Servo_StyleSet_NoteStyleSheetsChanged take a set of origi…
0cf487b 
…ns to dirty.
@heycam
geckolib: Add FFI function to get stylesheet origin.
9ef3871
@heycam
geckolib: Only dirty the relevant origin when stylesheets are added o…
22a6a2c 
…r removed.
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/data.rs, components/style/gecko_bindings/sugar/mod.rs, components/style/stylesheets/origin.rs, components/style/stylist.rs, components/style/invalidation/media_queries.rs and 3 more
  • @canaltinova: components/style/gecko/data.rs, components/style/gecko_bindings/sugar/mod.rs, components/style/stylesheets/origin.rs, components/style/stylist.rs, components/style/invalidation/media_queries.rs and 3 more
  • @emilio: components/style/gecko/data.rs, components/style/gecko_bindings/sugar/mod.rs, components/style/stylesheets/origin.rs, components/style/stylist.rs, components/style/invalidation/media_queries.rs and 4 more

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 13, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 13, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 22a6a2c has been approved by emilio

@highfive highfive assigned emilio and unassigned asajeffrey Aug 13, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 13, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 22a6a2c with merge c00e410...

bors-servo pushed a commit that referenced this pull request Aug 13, 2017
Auto merge of #18060 - heycam:single-origin, r=emilio
c00e410 
style: Don't rebuild cascade origins that haven't changed.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1382925.
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 13, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 13, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 13, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit d6856c0 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 13, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d6856c0 with merge b1d7b6b...

bors-servo pushed a commit that referenced this pull request Aug 13, 2017
Auto merge of #18060 - heycam:single-origin, r=emilio
b1d7b6b 
style: Don't rebuild cascade origins that haven't changed.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1382925.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18060)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing b1d7b6b to master...

@bors-servo bors-servo merged commit d6856c0 into servo:master Aug 13, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@heycam @highfive @bors-servo @asajeffrey @emilio