Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geckolib: Return @font-face rules to Gecko in the expected cascade order. #18067

Merged
merged 1 commit into from Aug 14, 2017

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Aug 14, 2017

From https://bugzilla.mozilla.org/show_bug.cgi?id=1389937. Reviewed by Xidorn there. Waiting until try server is back up and running before landing this, though.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets/origin.rs
  • @canaltinova: components/style/stylesheets/origin.rs
  • @emilio: ports/geckolib/glue.rs, components/style/stylesheets/origin.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 14, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 14, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit f26a7e9 with merge 91a8c3c...

bors-servo pushed a commit that referenced this pull request Aug 14, 2017
geckolib: Return @font-face rules to Gecko in the expected cascade order.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1389937.  Reviewed by Xidorn there.  Waiting until try server is back up and running before landing this, though.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@heycam
Copy link
Contributor Author

heycam commented Aug 14, 2017

@bors-servo r=xidorn

@bors-servo
Copy link
Contributor

📌 Commit f26a7e9 has been approved by xidorn

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 14, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit f26a7e9 with merge b0422b8...

bors-servo pushed a commit that referenced this pull request Aug 14, 2017
geckolib: Return @font-face rules to Gecko in the expected cascade order.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1389937.  Reviewed by Xidorn there.  Waiting until try server is back up and running before landing this, though.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: xidorn
Pushing b0422b8 to master...

@bors-servo bors-servo merged commit f26a7e9 into servo:master Aug 14, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants