style: paint-order serialization fixes. #18627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozReview-Commit-ID: 8hDAKZANOro Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
We share value representation, so there's no reason to do this in a more complex way. MozReview-Commit-ID: BITfCPqTkal Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
This matches Gecko, and fixes the last reported case in bug 1397619. MozReview-Commit-ID: 4Z7GeaokKE1 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
r? @nox |
nox
reviewed
Sep 25, 2017
| (self.0 >> pos * SHIFT) & MASK | ||
| fn order_at(&self, pos: u8) -> PaintOrder { | ||
| // Safe because PaintOrder covers all possible patterns. | ||
| unsafe { ::std::mem::transmute((self.0 >> pos * SHIFT) & MASK) } |
There was a problem hiding this comment.
Why not just store a PaintOrder in SpecifiedValue?
There was a problem hiding this comment.
(There are three packed values, so it's not clear to me how could I do that)
|
Nice. @bors-servo r+ |
|
📌 Commit 638ba2c has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Sep 25, 2017
style: paint-order serialization fixes. See each commit for details. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18627) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for details.
This change is