Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Don't error out on trailing whitespace in attr() #18644

Merged
merged 1 commit into from Sep 27, 2017
Merged

stylo: Don't error out on trailing whitespace in attr() #18644

merged 1 commit into from Sep 27, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Sep 26, 2017 •
edited by SimonSapin

r=bz bug 1403282

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/mod.rs
  • @canaltinova: components/style/values/specified/mod.rs
  • @emilio: components/style/values/specified/mod.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 26, 2017
@Manishearth
Copy link
Member Author

@bors-servo r=bz

@bors-servo
Copy link
Contributor

📌 Commit 2e1359b has been approved by bz

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 26, 2017
@bholley
Copy link
Contributor

bholley commented Sep 26, 2017

@bors-servo p=5

webcompat regression fix

@upsuper
Copy link
Contributor

upsuper commented Sep 27, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 2e1359b with merge 97227aa...

bors-servo pushed a commit that referenced this pull request Sep 27, 2017
Auto merge of #18644 - Manishearth:stylo-attr-ws, r=bz
97227aa 
stylo: Don't error out on trailing whitespace in attr()

r=bz bug 1403282

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18644)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bz
Pushing 97227aa to master...

@bors-servo bors-servo merged commit 2e1359b into servo:master Sep 27, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 27, 2017
@Manishearth Manishearth deleted the stylo-attr-ws branch July 11, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Manishearth @highfive @bors-servo @bholley @upsuper @wafflespeanut