Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pseudo-element properly in HasAuthorSpecifiedRules. #18823

Merged
merged 1 commit into from Oct 11, 2017
Merged

Support pseudo-element properly in HasAuthorSpecifiedRules. #18823

merged 1 commit into from Oct 11, 2017

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Oct 10, 2017 •
edited by SimonSapin

This is the Servo side change of bug 1401825.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, ports/geckolib/glue.rs, components/style/rule_tree/mod.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/rule_tree/mod.rs
  • @emilio: components/style/gecko/generated/bindings.rs, ports/geckolib/glue.rs, components/style/rule_tree/mod.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 10, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Oct 10, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 0c40ae7 has been approved by emilio

@highfive highfive assigned emilio and unassigned mbrubeck Oct 10, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 10, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 0c40ae7 with merge 3c6e7b5...

bors-servo pushed a commit that referenced this pull request Oct 10, 2017
Auto merge of #18823 - upsuper:author-pseudo, r=emilio
3c6e7b5 
Support pseudo-element properly in HasAuthorSpecifiedRules.

This is the Servo side change of [bug 1401825](https://bugzilla.mozilla.org/show_bug.cgi?id=1401825).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18823)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 3c6e7b5 to master...

@bors-servo bors-servo merged commit 0c40ae7 into servo:master Oct 11, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 11, 2017
@upsuper upsuper deleted the author-pseudo branch October 11, 2017 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@upsuper @highfive @bors-servo @mbrubeck @emilio