New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test-stylo compile an empty crate on Windows without Gecko #19003
Conversation
Heads up! This PR modifies the following files:
|
Running try with only the intermediate commit for now, to see if linking indeed fails: @bors-servo try |
Make test-stylo compile an empty crate on Windows without Gecko That is, in cases where it would fail to link. This will help make Rust CI be gated on compiling Stylo: rust-lang/rust#44603 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19003) <!-- Reviewable:end -->
💔 Test failed - windows-msvc-dev |
Got the expected linking failures. (See below.) I’ve pushed the commit that should fix it. This is ready for review.
|
That is, in cases where it would fail to link. This will help make Rust CI be gated on compiling Stylo: rust-lang/rust#44603
Exercise the previous commit’s fix. This used to fail to link: rust-lang/rust#44603 (comment)
ae31d67
to
4c36ba1
Compare
Commits swapped per reviewer request. @bors-servo r=emilio |
📌 Commit 4c36ba1 has been approved by |
Make test-stylo compile an empty crate on Windows without Gecko That is, in cases where it would fail to link. This will help make Rust CI be gated on compiling Stylo: rust-lang/rust#44603 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19003) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
That is, in cases where it would fail to link.
This will help make Rust CI be gated on compiling Stylo: rust-lang/rust#44603
This change is