style: Fix detection of animations to avoid style flushing in getComputedStyle. #19016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
emilio
force-pushed
the
animation-avoid-flush-not-quite
branch
from
5de2004
to
2895e33
Compare
|
@bors-servo r=hiro |
|
📌 Commit 2895e33 has been approved by |
highfive
added
S-awaiting-merge
…utedStyle. This fixes multiple things: * EffectCompositor was using the light tree instead of the flat tree. * When we insert an element inside the document, we may not style it right away (we mark it for lazy frame construction with the NODE_NEEDS_FRAME). Since we trigger animations and transitions from the traversal, we can't skip flushing if we call getComputedStyle on any of those. Bug: 1406750 Reviewed-by: hiro MozReview-Commit-ID: DpAhmLH3uJ2
emilio
force-pushed
the
animation-avoid-flush-not-quite
branch
from
2895e33
to
05beeee
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=hiro
|
|
📌 Commit 05beeee has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 25, 2017
style: Fix detection of animations to avoid style flushing in getComputedStyle. This fixes multiple things: * EffectCompositor was using the light tree instead of the flat tree. * When we insert an element inside the document, we may not style it right away (we mark it for lazy frame construction with the NODE_NEEDS_FRAME). Since we trigger animations and transitions from the traversal, we can't skip flushing if we call getComputedStyle on any of those. Bug: 1406750 Reviewed-by: hiro MozReview-Commit-ID: DpAhmLH3uJ2 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19016) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple things:
EffectCompositor was using the light tree instead of the flat tree.
When we insert an element inside the document, we may not style it right away
(we mark it for lazy frame construction with the NODE_NEEDS_FRAME). Since we
trigger animations and transitions from the traversal, we can't skip flushing
if we call getComputedStyle on any of those.
Bug: 1406750
Reviewed-by: hiro
MozReview-Commit-ID: DpAhmLH3uJ2
This change is