Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Make the SelectorMap API slightly nicer. #19059

Merged
merged 1 commit into from Oct 30, 2017
Merged

style: Make the SelectorMap API slightly nicer. #19059

merged 1 commit into from Oct 30, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Oct 30, 2017 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/invalidation/element/collector.rs, components/style/selector_map.rs, components/style/stylist.rs
  • @canaltinova: components/style/invalidation/element/collector.rs, components/style/selector_map.rs, components/style/stylist.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 30, 2017
@nox
Copy link
Contributor

nox commented Oct 30, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 7861ec1 has been approved by nox

@highfive highfive assigned nox and unassigned metajack Oct 30, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 30, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 7861ec1 with merge 1b73cf3...

bors-servo pushed a commit that referenced this pull request Oct 30, 2017
Auto merge of #19059 - emilio:selector-map-nicer, r=nox
1b73cf3 
style: Make the SelectorMap API slightly nicer.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19059)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 1b73cf3 to master...

@bors-servo bors-servo merged commit 7861ec1 into servo:master Oct 30, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilio @highfive @nox @bors-servo @metajack