Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cancellation map and ResourceId from the net* components #19328

Merged
merged 1 commit into from Nov 22, 2017
Merged

Remove cancellation map and ResourceId from the net* components #19328

merged 1 commit into from Nov 22, 2017

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Nov 21, 2017 •
edited by SimonSapin

Fixes #19327

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net_traits/lib.rs, components/net_traits/lib.rs

@highfive
Copy link

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 21, 2017
@KiChjang
Copy link
Contributor

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

📌 Commit d55e0fa has been approved by KiChjang

@highfive highfive assigned KiChjang and unassigned metajack Nov 21, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 21, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d55e0fa with merge 78fb3c2...

bors-servo pushed a commit that referenced this pull request Nov 22, 2017
Auto merge of #19328 - Eijebong:remove_old_cancellation_code, r=KiChjang
78fb3c2 
Remove cancellation map and ResourceId from the net* components

Fixes #19327

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19328)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: KiChjang
Pushing 78fb3c2 to master...

@bors-servo bors-servo merged commit d55e0fa into servo:master Nov 22, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Eijebong @highfive @KiChjang @bors-servo @metajack