style: Make anon boxes account for :visited. #19551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
r? @heycam |
emilio
force-pushed
the
anon-box-visited
branch
from
81effdd
to
07fdc2d
Compare
heycam
approved these changes
Dec 14, 2017
| ) -> Arc<ComputedValues> { | ||
| // NOTE(emilio): We skip calculating the proper layout parent style |
There was a problem hiding this comment.
I see the comment in compute_pseudo_element_style_with_inputs already mentions this, but maybe it's to maintain the concrete example of fieldset?
This should fix one of the test failures of: https://bugzilla.mozilla.org/show_bug.cgi?id=616436
emilio
force-pushed
the
anon-box-visited
branch
from
07fdc2d
to
604c520
Compare
|
@bors-servo r=heycam |
|
📌 Commit 604c520 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Dec 14, 2017
style: Make anon boxes account for :visited. This should fix one of the test failures of: https://bugzilla.mozilla.org/show_bug.cgi?id=616436 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19551) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix one of the test failures of:
https://bugzilla.mozilla.org/show_bug.cgi?id=616436
This change is