You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should decide whether they should live in computed or specified. I don't have a particularly strong preference, and the only argument I've heard (from @mauricioc and @nox IIRC) is that ideally specified modules shouldn't depend on computed ones, and making complex cases depend on that makes the code intrincate.
I think that's a valid point, so lacking other arguments I'd be fine moving all them to computed. But I bet there can be other arguments in the other direction, so given this isn't particularly urgent we can wait and discuss for as long as needed :)
IMO, I'll vote for impl ToComputedValue inside specified modules because I think it's reasonable to make associated types of impl ToComputedValue with its computed module.
We can see that we'd like to implement ToComputedValue trait and make its associated type with its own computed module.
I'm also fine for moving all of them in specified modules but just share my opinion.
Right now:
So that's... not very consistent.
The text was updated successfully, but these errors were encountered: