style: Make GeckoElement::has_class faster. #19787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've verified that current libxul, at least for Linux, doesn't manage to pull the branch out.
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo r+ |
|
📌 Commit c44e038 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 16, 2018
style: Make GeckoElement::has_class faster. By force-inlining the fast path, and pulling out a branch that rust didn't manage to pull out. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19787) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-unit |
highfive
added
S-tests-failed
It's easier, and probably faster, than trying to inline the function call to Gecko. This symbol is in libxul.so as of right now.
highfive
added
S-awaiting-review
|
@bors-servo r=bholley
|
|
📌 Commit e55bb3e has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 16, 2018
style: Make GeckoElement::has_class faster. By force-inlining the fast path, and pulling out a branch that rust didn't manage to pull out. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19787) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By force-inlining the fast path, and pulling out a branch that rust didn't manage to pull out.
This change is