style: Minor nits on the alignment properties. #19850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
I'm going to touch this in a bit, let's do it a bit less painful. MozReview-Commit-ID: LhBNMkUXlUK
nox
approved these changes
Jan 24, 2018
| #[link_name = "\u{1}_ZN10nsCSSProps34kAutoCompletionAlignJustifyContentE"] | ||
| pub static mut nsCSSProps_kAutoCompletionAlignJustifyContent: | ||
| #[link_name = "\u{1}_ZN10nsCSSProps34kAutoCompletionContentDistributionE"] | ||
| pub static mut nsCSSProps_kAutoCompletionContentDistribution: |
There was a problem hiding this comment.
Is this change intended? Please ELI5.
There was a problem hiding this comment.
Yeah, it is not, but it's harmless anyway.
align-content and justify-content will have different types in a second. MozReview-Commit-ID: 5JDeR5kXZNP
This matches the spec term and, again, the two properties will have different grammars soon. MozReview-Commit-ID: 8f8JXj2NnCi
|
@bors-servo r=nox
|
|
📌 Commit 711ea51 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 24, 2018
style: Minor nits on the alignment properties. I'm going to touch this in a bit, let's do it a bit less painful. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19850) <!-- Reviewable:end -->
|
💔 Test failed - arm32 |
highfive
added
S-tests-failed
|
@bors-servo retry
|
bors-servo
pushed a commit
that referenced
this pull request
Jan 24, 2018
style: Minor nits on the alignment properties. I'm going to touch this in a bit, let's do it a bit less painful. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19850) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
💔 Test failed - arm32 |
highfive
removed
the
S-awaiting-merge
|
@bors-servo retry
|
bors-servo
pushed a commit
that referenced
this pull request
Jan 24, 2018
style: Minor nits on the alignment properties. I'm going to touch this in a bit, let's do it a bit less painful. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19850) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
💔 Test failed - arm32 |
highfive
added
S-tests-failed
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 24, 2018
style: Minor nits on the alignment properties. I'm going to touch this in a bit, let's do it a bit less painful. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19850) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 29, 2018
style: Update css-align to the spec (mostly) This is on top of #19850. This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1430817, and updates us to the current version of the css-align spec. The only remaining change is the justify-items: auto FIXME. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19851) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to touch this in a bit, let's do it a bit less painful.
This change is