Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Cleanup serialization a bit. #20049

Merged
merged 5 commits into from Feb 14, 2018
Merged

style: Cleanup serialization a bit. #20049

merged 5 commits into from Feb 14, 2018

Conversation

emilio
Copy link
Member

@emilio emilio commented Feb 14, 2018 •
edited by SimonSapin

Mostly minor cleanups, in preparation for more refactoring.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/declaration_block.rs
  • @canaltinova: components/style/properties/declaration_block.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 14, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Feb 14, 2018

r? @nox or @SimonSapin

@highfive highfive assigned nox and unassigned metajack Feb 14, 2018
@SimonSapin
Copy link
Member

@bors-servo r+

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@bors-servo
Copy link
Contributor

📌 Commit 502b734 has been approved by SimonSapin

@highfive highfive assigned SimonSapin and unassigned nox Feb 14, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 14, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 502b734 with merge 6f82110...

bors-servo pushed a commit that referenced this pull request Feb 14, 2018
Auto merge of #20049 - emilio:cleanup-serialization-a-bit, r=SimonSapin
6f82110 
style: Cleanup serialization a bit.

Mostly minor cleanups, in preparation for more refactoring.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20049)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 14, 2018
@emilio
Copy link
Member Author

emilio commented Feb 14, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm64, linux-dev, mac-dev-unit, mac-rel-css1, mac-rel-wpt4 are reusable. Rebuilding only arm32, linux-rel-css, linux-rel-wpt, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 6f82110 to master...

@bors-servo bors-servo merged commit 502b734 into servo:master Feb 14, 2018
@emilio emilio deleted the cleanup-serialization-a-bit branch February 14, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@emilio @highfive @SimonSapin @bors-servo @metajack @nox