Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement step 3 of the inner text collection steps algorithm #20159

Open
ferjm opened this issue Mar 1, 2018 · 0 comments
Open

Properly implement step 3 of the inner text collection steps algorithm #20159

ferjm opened this issue Mar 1, 2018 · 0 comments

Comments

@ferjm
Copy link
Contributor

ferjm commented Mar 1, 2018

Spec: https://html.spec.whatwg.org/multipage/dom.html#inner-text-collection-steps

If node is not being rendered, then return items. For the purpose of this step, the following elements must act as described if the computed value of the 'display' property is not 'none':
- select elements have an associated non-replaced inline CSS box whose child boxes include only those of optgroup and option element child nodes;
- optgroup elements have an associated non-replaced block-level CSS box whose child boxes include only those of option element child nodes; and
- option element have an associated non-replaced block-level CSS box whose child boxes are as normal for non-replaced block-level CSS boxes.

The code is currently ignoring the select/optgroup/option exceptions.

This makes a test like <div>a<select><option></select>bc give a instead of a\nbc as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant