Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some random improvements to derived style code #20254

Merged
merged 7 commits into from Mar 9, 2018
Merged

Some random improvements to derived style code #20254

merged 7 commits into from Mar 9, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Mar 9, 2018 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

highfive commented Mar 9, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/url.rs, components/style/values/specified/mod.rs, components/style/values/generics/transform.rs, components/style/values/animated/mod.rs, components/style/values/generics/grid.rs and 5 more
  • @canaltinova: components/style/gecko/url.rs, components/style/values/specified/mod.rs, components/style/values/generics/transform.rs, components/style/values/animated/mod.rs, components/style/values/generics/grid.rs and 5 more
  • @emilio: components/style/gecko/url.rs, components/style/values/specified/mod.rs, components/style/values/generics/transform.rs, components/style/values/animated/mod.rs, components/style/values/generics/grid.rs and 5 more

@highfive
Copy link

highfive commented Mar 9, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 9, 2018
emilio
emilio approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with a comment in the commit message about the reference box thing.

@nox
Copy link
Contributor Author

nox commented Mar 9, 2018

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit afaa00a has been approved by emilio

@highfive highfive assigned emilio and unassigned glennw Mar 9, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 9, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit afaa00a with merge 664efab...

bors-servo pushed a commit that referenced this pull request Mar 9, 2018
Auto merge of #20254 - servo:derive-all-the-things, r=emilio
664efab 
Some random improvements to derived style code

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20254)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 664efab to master...

@bors-servo bors-servo merged commit afaa00a into master Mar 9, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2018
@nox nox deleted the derive-all-the-things branch March 9, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @bors-servo @emilio @glennw