Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline shows incorrectly #20866

Open
CYBAI opened this issue May 26, 2018 · 4 comments
Open

Outline shows incorrectly #20866

CYBAI opened this issue May 26, 2018 · 4 comments

Comments

@CYBAI
Copy link
Member

CYBAI commented May 26, 2018

URL: http://prismjs.com/

Scroll to the Basic Usage section and check the red outline in the code block

In Firefox Nightly:
image

In Servo:
image

Note: Servo is built from 4e6b100

Tested in macOS 10.12.6

@tigercosmos
Copy link
Contributor

Might be caused by the CSS
default

@CYBAI
Copy link
Member Author

CYBAI commented May 26, 2018

Simplified test case

<style>
  code {
    outline: .4em solid red;
    outline-offset: .4em;
  }
</style>

<code>
  <span>
    <span>link</span>
    <span>href</span>
  </span>
</code>

image

Simplified test case without outline-offset

<style>
  code {
    outline: .4em solid red;
  }
</style>

<code>
  <span>
    <span>link</span>
    <span>href</span>
  </span>
</code>

image

@tigercosmos
Copy link
Contributor

/// Adds the display items necessary to paint the outline of this fragment to the display list
/// if necessary.
fn build_display_list_for_outline_if_applicable(
&self,
state: &mut DisplayListBuildState,
style: &ComputedValues,
bounds: Rect<Au>,
clip: Rect<Au>,
);

@dralley
Copy link
Contributor

dralley commented Apr 6, 2020

Still reproducable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants