Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile to Android anymore (Mac) #21773

Closed
paulrouget opened this issue Sep 21, 2018 · 5 comments
Closed

Can't compile to Android anymore (Mac) #21773

paulrouget opened this issue Sep 21, 2018 · 5 comments
Labels
A-build Related to or part of the build process P-android Android devices

Comments

@paulrouget
Copy link
Contributor

paulrouget commented Sep 21, 2018

error[E0063]: missing field `__bindgen_padding_0` in initializer of `mozjs_sys::root::JS::ForOfIterator`
   --> /Users/paul/.cargo/registry/src/github.com-1ecc6299db9ec823/mozjs-0.9.1/src/conversions.rs:604:28
    |
604 |         let mut iterator = ForOfIterator {
    |                            ^^^^^^^^^^^^^ missing `__bindgen_padding_0`
error: aborting due to previous error

That was solved by servo/rust-mozjs@7f313c9 which never made it to master.

I was using this in the past: #21469 (comment)

But mozjs has been updated to 0.9.1 so it doesn't work anymore.

@paulrouget paulrouget changed the title Can't compile for Android anymore (both Linux and Mac) Can't compile to Android anymore (both Linux and Mac) Sep 21, 2018
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 21, 2018

For Linux, we only need servo/rust-mozjs@7f313c9, for mac we need both servo/rust-mozjs@7f313c9 and servo/mozjs#148.

@SimonSapin
Copy link
Member

I’ve seen something similar before with __bindgen_align the problem went away by upgrading libclang. (I think from version 4 to 6? I don’t remember exactly.) Maybe upgrading could help here as well?

@paulrouget
Copy link
Contributor Author

So that would require a ndk update :(

@SimonSapin
Copy link
Member

This is the libclang used by bindgen, not the NDK’s clang used to compile C++ code. (By the way @emilio, does it sound like a problem that they’re not necessarily the same version?)

@tigercosmos tigercosmos added P-android Android devices A-build Related to or part of the build process labels Sep 21, 2018
@paulrouget paulrouget changed the title Can't compile to Android anymore (both Linux and Mac) Can't compile to Android anymore (Mac) Sep 26, 2018
@paulrouget
Copy link
Contributor Author

This is now fixed on both Mac and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Related to or part of the build process P-android Android devices
Projects
None yet
Development

No branches or pull requests

3 participants