You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I mentioned in #22736 (comment), after implementing FormData in Vec<(LocalName, FormDatum)> in #22736, we only passed the keys test case. We cannot pass these test cases which has values comparison with File because we don't have the same lastModified and filename between BlobImpl::Memory and the File object constructed by File constructor.
In Gecko and Blink, both of them have a ToFile function for Blob
/// Memory-based blob, whose content lives in the script process
Memory(Vec<u8>),
So, to have more information for Blob in script thread, it's better to save more necessary fields like what FileBlob did.
We should have a new struct like MemoryBlob to save filename and last_modified timestamp (and more fields if needed). With this implementation, we should be able to pass the values related tests in xhr/formdata-foreach.html
As I mentioned in #22736 (comment), after implementing
FormData
inVec<(LocalName, FormDatum)>
in #22736, we only passed thekeys
test case. We cannot pass these test cases which hasvalues
comparison withFile
because we don't have the samelastModified
andfilename
betweenBlobImpl::Memory
and theFile
object constructed by File constructor.In Gecko and Blink, both of them have a
ToFile
function forBlob
In Servo, we have a similar thing which is the
BlobImpl::Memory
; however, we only save thebytes
for script thread.servo/components/script/dom/blob.rs
Lines 39 to 40 in c3608c0
So, to have more information for Blob in script thread, it's better to save more necessary fields like what
FileBlob
did.We should have a new struct like
MemoryBlob
to savefilename
andlast_modified
timestamp (and more fields if needed). With this implementation, we should be able to pass thevalues
related tests inxhr/formdata-foreach.html
Ex.
The text was updated successfully, but these errors were encountered: