Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add T-linux-wpt label #30749

Closed
Loirooriol opened this issue Nov 18, 2023 · 4 comments
Closed

Add T-linux-wpt label #30749

Loirooriol opened this issue Nov 18, 2023 · 4 comments

Comments

@Loirooriol
Copy link
Contributor

To run WPT both in 2013 and 2020.

Right now I either need to

  • Use T-full, which tests all linux, windows and mac, and includes unit tests. Sometimes I don't care about that.
  • Use both T-linux-wpt-2013 and T-linux-wpt-2020, which triggers 2 different actions, and compiles twice.
@sagudev
Copy link
Member

sagudev commented Nov 18, 2023

#30694 already has logic for it, only GH label is missing.

@mrobinson
Copy link
Member

To run WPT both in 2013 and 2020.
* Use both T-linux-wpt-2013 and T-linux-wpt-2020, which triggers 2 different actions, and compiles twice.

This doesn't actually compile twice depending on timing of the GitHub Actions. I've noticed that most of the time, this only does one build. I think we can make this work even more consistently with https://docs.github.com/en/actions/using-jobs/using-concurrency. This should allow us to make sure that labels applied at the same time are combined into the same job.

@mrobinson
Copy link
Member

The benefit of using concurrency is that it should allow any combination of jobs without having to add a bunch of extra labels, if we can get it working properly. See #30756.

@sagudev
Copy link
Member

sagudev commented Mar 3, 2024

Merging of wpt runs was done in #31347. Also try-parser already supports linux-wpt and wpt so it's just matter of adding new tags to github if we really needed to:

elif s in ["wpt", "linux-wpt"]:
return JobConfig("Linux WPT", Workflow.LINUX, unit_tests=True, wpt_layout=Layout.all())

@sagudev sagudev closed this as completed Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants