New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebIDL impl: remove unsafe JSObject when returning a ReadableStream #30891

Open

gterzian opened this issue Dec 19, 2023 · 3 comments

Labels

A-content/script C-assigned I-safety L-javascript

Member

gterzian commented Dec 19, 2023

Part of #30862

Same as #30889

Depends on #29881

All the below should return a concrete, and safe, ReadableStream object.

servo/components/script/dom/blob.rs

Line 234 in 8bbcf0a

fn Stream(&self, _cx: JSContext) -> NonNull<JSObject> {

servo/components/script/dom/request.rs

Line 603 in 8bbcf0a

fn GetBody(&self, _cx: SafeJSContext) -> Option<NonNull<JSObject>> {

servo/components/script/dom/response.rs

Line 360 in 8bbcf0a

fn GetBody(&self, _cx: SafeJSContext) -> Option<NonNull<JSObject>> {

The text was updated successfully, but these errors were encountered:

gterzian added I-safety A-content/script L-javascript labels

gterzian mentioned this issue

WebIDL impl: Replace use of NonNull<JSObject> #30889

Open

SummerGram commented Feb 16, 2024

@servo-highfive assign me

servo-highfive added the C-assigned label

servo-highfive commented Feb 16, 2024

Hey @SummerGram! Thanks for your interest in working on this issue. It's now assigned to you!

Member Author

gterzian commented Feb 16, 2024 •

edited

@SummerGram Thank you for your interest! This one is complicated and there is already a WIP at #29881

I can help you find one that would match your current skillset better. I've messaged you in the relevant topic on zullip...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment