Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebIDL: use FLoat32Array in XRView #31046

Closed
gterzian opened this issue Jan 10, 2024 · 3 comments · Fixed by #31077
Closed

WebIDL: use FLoat32Array in XRView #31046

gterzian opened this issue Jan 10, 2024 · 3 comments · Fixed by #31077
Assignees
@tannal
Labels
A-content/script Related to the script thread E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss I-safety Some piece of code violates memory safety guarantees.

Comments

@gterzian
Copy link
Member

gterzian commented Jan 10, 2024 •
edited

Depends on #30990

How to do it:

  1. In CodegenRust.py remove XRView from the list in todo_switch_float_32.
  2. Replace proj: Heap<*mut JSObject> with HeapFloat32Array
  3. Change ProjectionMatrix to return a Float32Array by using set_data and doing the same as in AudioBuffer::GetChannelData

Any questions, ask here or in https://servo.zulipchat.com/
@gterzian gterzian added E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss A-content/script Related to the script thread labels Jan 10, 2024
@gterzian gterzian mentioned this issue Jan 10, 2024
Closed
@gterzian
Copy link
Member Author

Part of #30862

@gterzian gterzian added the I-safety Some piece of code violates memory safety guarantees. label Jan 11, 2024
@tannal
Copy link
Contributor

tannal commented Jan 12, 2024

Hello, @gterzian , I would like to take this up.

@gterzian
Copy link
Member Author

Go for it, thanks!

@tannal tannal mentioned this issue Jan 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannal tannal

Labels
A-content/script Related to the script thread E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss I-safety Some piece of code violates memory safety guarantees.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use FLoat32Array in XRView tannal/servo
2 participants
@gterzian @tannal