Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebIDL: use FLoat32Array in XRRigidTransform #31047

Closed
gterzian opened this issue Jan 10, 2024 · 1 comment · Fixed by #31076
Closed

WebIDL: use FLoat32Array in XRRigidTransform #31047

gterzian opened this issue Jan 10, 2024 · 1 comment · Fixed by #31076
Labels
A-content/script Related to the script thread E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss I-safety Some piece of code violates memory safety guarantees.

Comments

@gterzian
Copy link
Member

gterzian commented Jan 10, 2024

Depends on #30990

How to do it:

  1. In CodegenRust.py remove XRRigidTransform from the list in todo_switch_float_32.
  2. Replace matrix: Heap<*mut JSObject> with HeapFloat32Array.
  3. Replace Matrix to return a Float32Array, by using set_data and doing the same as in AudioBuffer::GetChannelData

Any questions, ask here or in https://servo.zulipchat.com/

@gterzian gterzian added E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss A-content/script Related to the script thread labels Jan 10, 2024
@gterzian
Copy link
Member Author

part of #30862

@gterzian gterzian added the I-safety Some piece of code violates memory safety guarantees. label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/script Related to the script thread E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss I-safety Some piece of code violates memory safety guarantees.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant