Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servoshell: add a spinner that indicates when the page is loading #31689

Closed
delan opened this issue Mar 15, 2024 · 1 comment · Fixed by #31713
Closed

servoshell: add a spinner that indicates when the page is loading #31689

delan opened this issue Mar 15, 2024 · 1 comment · Fixed by #31713
Assignees
Labels
A-servoshell B-newcomer-not-yet Issues that may become newcomer-friendly after blockers are resolved.

Comments

@delan
Copy link
Sponsor Member

delan commented Mar 15, 2024

When the minibrowser is enabled, add an egui spinner to the location bar when the page is loading.

Watch for EmbedderMsg::LoadStart, EmbedderMsg::HeadParsed, and EmbedderMsg::LoadComplete events, and keep track of whether the page is currently loading in Minibrowser.

This may be a good newcomer issue once #31688 is fixed.

image

@frereit
Copy link
Contributor

frereit commented Mar 17, 2024

Darn, I forgot to leave a comment here that I started work on this, sorry. I hope this didn't lead to doubled work but I've done some work in #31713. If anyone else also worked on this, maybe let me know and we can discuss the issue in more detail 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-servoshell B-newcomer-not-yet Issues that may become newcomer-friendly after blockers are resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants